Driver dispatch for PSA asymmetric encryption + RSA tests #5292

mprse · 2021-12-09T12:17:27Z

Description

Resolves #5250. Resolves #5249.

Driver dispatch for PSA asymmetric encryption.

Status

READY

Requires Backporting

Yes 2.x?

Migrations

NO

Todos

Impl for psa_asymmetric_decrypt
Add tests for asymmetric encrypt/decrypt
Add driver dispatch tests for RSA signatures

mprse · 2021-12-13T10:30:39Z

In this PR I also see the problem with windows build (but different than #5139 (comment)):

42>ClCompile:
         crypto_examples.c
    89>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\CodeAnalysis\Microsoft.CodeAnalysis.targets(214,5): error MSB4175: The task factory "CodeTaskFactory" could not be loaded from the assembly "C:\Program Files (x86)\MSBuild\12.0\bin\amd64\Microsoft.Build.Tasks.v12.0.dll". Could not find file 'C:\Users\Administrator\AppData\Local\Temp\j5mjvtfy.dll'. [C:\builds\workspace\mbed-tls-pr-merge_PR-5292-merge\worktrees\tmpjxoaly25\visualc\VS2010\rsa_verify_pss.vcxproj]
    89>Done Building Project "C:\builds\workspace\mbed-tls-pr-merge_PR-5292-merge\worktrees\tmpjxoaly25\visualc\VS2010\rsa_verify_pss.vcxproj" (Rebuild target(s)) -- FAILED.
    32>Done Building Project "C:\builds\workspace\mbed-tls-pr-merge_PR-5292-merge\worktrees\tmpjxoaly25\visualc\VS2010\rsa_verify_pss.vcxproj.metaproj" (Rebuild target(s)) -- FAILED.

mprse · 2021-12-22T08:58:00Z

I couldn't find test vectors for all functions/algorithms:

	hash sign	hash verify	message sign	message verify
PSA_ALG_RSA_PKCS1V15_SIGN_RAW	OK	OK
PSA_ALG_RSA_PKCS1V15_SIGN(PSA_ALG_SHA_256)		OK	OK	OK
PSA_ALG_RSA_PSS(PSA_ALG_SHA_256)		OK		OK
PSA_ALG_RSA_PSS_ANY_SALT(PSA_ALG_SHA_256)		OK		OK

	asym encrypt/decrypt
PSA_ALG_RSA_PKCS1V15_CRYPT	OK
PSA_ALG_RSA_OAEP(PSA_ALG_SHA_256)	OK

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

…encrypt Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

…decrypt Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Tested key types: PSA_ALG_RSA_PKCS1V15_SIGN_RAW PSA_ALG_RSA_PKCS1V15_SIGN(PSA_ALG_SHA_256) Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Tested algs: PSA_ALG_RSA_PKCS1V15_SIGN(PSA_ALG_SHA_256) Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

* Remove expected_output_data: since asymmetric encryption is randomized, it can't be useful. * The decryption check needs the private exponent, not the public exponent. * Use PSA macro for the expected ciphertext buffer size. * Move RSA sanity checks to their own function for clarity. * For RSAES-PKCS1-v1_5, check that the result of the private key operation has the form 0x00 0x02 ... 0x00 M where M is the plaintext. * For OAEP, check that the result of the private key operation starts with 0x00. The rest is the result of masking which it would be possible to check here, but not worth the trouble of implementing. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

mprse · 2022-03-08T12:09:03Z

pr-merge passes. CI can be considered as passed.

AndrzejKurek · 2022-03-10T13:24:32Z

tests/suites/test_suite_psa_crypto_driver_wrappers.function

+    psa_status_t forced_status_encrypt = forced_status_encrypt_arg;
+    psa_status_t expected_status_encrypt = expected_status_encrypt_arg;
+    psa_key_attributes_t attributes = PSA_KEY_ATTRIBUTES_INIT;
+    (void)expected_output_data;


space missing

AndrzejKurek · 2022-03-10T13:26:10Z

tests/suites/test_suite_psa_crypto_driver_wrappers.function

+    mbedtls_mpi_init( &X );
+#endif /* MBEDTLS_BIGNUM_C */
+
+    int ok = 0;


Maybe ret instead of ok?

We use the convention ret for (0 = success, MBEDTLS_ERR_xxx = error, sometimes >0 = output size). For boolean return values (1 = success, 0 = failure), we use a different variable name. In the test suites it's typically ok.

AndrzejKurek

Really minor changes suggested, but not required.

gilles-peskine-arm

Thanks for doing those last changes. Looks good to me!

Please backport the improvements related to testing with signature to 2.28. I'm going to merge this pull request without waiting for a backport to avoid bitrot.

mprse added the needs-work label Dec 9, 2021

mprse added this to To Do in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 via automation Dec 9, 2021

mprse linked an issue Dec 9, 2021 that may be closed by this pull request

Driver dispatch for PSA asymmetric encryption #5250

Closed

mprse force-pushed the asym_encrypt branch 4 times, most recently from ce99bd8 to 089f9f3 Compare December 13, 2021 09:01

mprse moved this from To Do to In Development in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 Dec 14, 2021

mprse force-pushed the asym_encrypt branch from fd00924 to 69bdaf2 Compare December 20, 2021 08:52

mprse moved this from In Development to In Review in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 Dec 20, 2021

mprse changed the title ~~Driver dispatch for PSA asymmetric encryption~~ Driver dispatch for PSA asymmetric encryption + RSA tests Dec 20, 2021

mprse linked an issue Dec 22, 2021 that may be closed by this pull request

Driver dispatch tests for RSA #5249

Closed

mprse added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Dec 22, 2021

mprse added component-psa PSA keystore/dispatch layer (storage, drivers, …) and removed needs-work labels Jan 3, 2022

mprse moved this from In Review to To Do in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 Jan 3, 2022

mprse added 11 commits January 10, 2022 12:55

psa_asymmetric_encrypt: access the key store and call driver dispatch

19e6142

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

psa_asymmetric_encrypt: add test driver impl

b6a6650

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

psa_asymmetric_encrypt: move build-in impl to mbedtls_psa_asymmetric_…

234f318

…encrypt Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

psa_asymmetric_decrypt: access the key store and call driver dispatch

8d45c00

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

psa_asymmetric_decrypt: add test driver impl

71284ea

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

psa_asymmetric_decrypt: move build-in impl to mbedtls_psa_asymmetric_…

2ecfd57

…decrypt Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Add driver tests for asymmetric encrypt/decrypt

06a9fee

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

test_suite_psa_crypto_driver_wrappers.function: trim trailing whitespace

de13365

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Add driver dispatch tests for RSA hash sign

9b52a15

Tested key types: PSA_ALG_RSA_PKCS1V15_SIGN_RAW PSA_ALG_RSA_PKCS1V15_SIGN(PSA_ALG_SHA_256) Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Add driver dispatch tests for RSA hash verify

d06e927

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

Add driver dispatch tests for RSA message sign

66ed8d6

Tested algs: PSA_ALG_RSA_PKCS1V15_SIGN(PSA_ALG_SHA_256) Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

gilles-peskine-arm added the needs-work label Mar 2, 2022

mprse added 2 commits March 7, 2022 10:49

Change names rsa->asymmetric_encryption

7a58208

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

WIP: Add asymmetric_encrypt test case

72373f3

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

mprse dismissed AndrzejKurek’s stale review via 72373f3 March 7, 2022 15:48

gilles-peskine-arm removed the approved Design and code approved - may be waiting for CI or backports label Mar 7, 2022

gilles-peskine-arm added needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels Mar 7, 2022

mprse added 3 commits March 8, 2022 10:31

asymmetric_encrypt: add remining test driver cases

d5e5c8b

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

asymmetric_encrypt: handle forced output

b6bdebd

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

asymmetric_encryption.h: trim trailing spaces

f8614a0

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

mprse removed the needs-ci Needs to pass CI tests label Mar 8, 2022

mprse requested review from gilles-peskine-arm and AndrzejKurek March 8, 2022 12:07

mprse moved this from In Development to In Review in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 Mar 8, 2022

AndrzejKurek reviewed Mar 10, 2022

View reviewed changes

AndrzejKurek approved these changes Mar 10, 2022

View reviewed changes

bensze01 moved this from In Review to Has Approval in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 Mar 10, 2022

gilles-peskine-arm mentioned this pull request Mar 10, 2022

Backport PSA signature driver dispatch tests to 2.28 #5618

Closed

gilles-peskine-arm approved these changes Mar 10, 2022

View reviewed changes

gilles-peskine-arm merged commit afb4828 into Mbed-TLS:development Mar 10, 2022

OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 automation moved this from Has Approval to Done Mar 10, 2022

gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Mar 10, 2022

mprse mentioned this pull request Mar 11, 2022

Backport RSA signature/verification tests #5619

Merged

daverodgman removed this from Done in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 Mar 30, 2022

gilles-peskine-arm mentioned this pull request Nov 2, 2023

psa_asymmetric_encrypt() doesn't work with opaque driver #8461

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Driver dispatch for PSA asymmetric encryption + RSA tests #5292

Driver dispatch for PSA asymmetric encryption + RSA tests #5292

mprse commented Dec 9, 2021 •

edited by gilles-peskine-arm

mprse commented Dec 13, 2021

mprse commented Dec 22, 2021

mprse commented Mar 8, 2022

AndrzejKurek Mar 10, 2022

AndrzejKurek Mar 10, 2022

gilles-peskine-arm Mar 10, 2022

AndrzejKurek left a comment

gilles-peskine-arm left a comment

Driver dispatch for PSA asymmetric encryption + RSA tests #5292

Driver dispatch for PSA asymmetric encryption + RSA tests #5292

Conversation

mprse commented Dec 9, 2021 • edited by gilles-peskine-arm

Description

Status

Requires Backporting

Migrations

Todos

mprse commented Dec 13, 2021

mprse commented Dec 22, 2021

mprse commented Mar 8, 2022

AndrzejKurek Mar 10, 2022

Choose a reason for hiding this comment

AndrzejKurek Mar 10, 2022

Choose a reason for hiding this comment

gilles-peskine-arm Mar 10, 2022

Choose a reason for hiding this comment

AndrzejKurek left a comment

Choose a reason for hiding this comment

gilles-peskine-arm left a comment

Choose a reason for hiding this comment

mprse commented Dec 9, 2021 •

edited by gilles-peskine-arm