-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix: mbedtls_ecdsa_verify_restartable fails with ECDSA_SIGN_ALT #7499
Bug Fix: mbedtls_ecdsa_verify_restartable fails with ECDSA_SIGN_ALT #7499
Conversation
Please add a signoff line to your commit message(s), otherwise we can't accept them. The DCO check needs to pass. |
Out of curiosity, which ATECC608 integration are you referring to? I don't recall seeing one that uses |
4bcec0e
to
b8661ba
Compare
DCO finished! I discovered this issue when attempting to use cryptoauthlib with mbedTLS 3 (upgrading from 2). ALT verify never would work with my ATECC608, so I always had it disabled. Non ALT verify worked with mbedTLS 2 because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the change is quite right. Also it needs a changelog entry.
When ECDSA_SIGN_ALT but not ECDSA_VERIFY_ALT, mbedtls_ecdsa_can_do was not being defined causing mbedtls_ecdsa_verify_restartable to always fail Signed-off-by: JonathanWitthoeft <jonw@gridconnect.com>
Signed-off-by: JonathanWitthoeft <jonw@gridconnect.com>
52bb7b3
to
9b26518
Compare
9eb233a
to
21ab6c2
Compare
Signed-off-by: JonathanWitthoeft <jonw@gridconnect.com>
21ab6c2
to
2a878a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @JonathanWitthoeft !
When ECDSA_SIGN_ALT but not ECDSA_VERIFY_ALT, mbedtls_ecdsa_can_do was not being defined causing mbedtls_ecdsa_verify_restartable to always fail
closes #7498
Description
This will support ATECC608 integration for signing but not verification.
Gatekeeper checklist
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.