Remove transparent key check in psa_asymmetric_encrypt/decrypto() #8481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `psa_asymmetric_encrypt()` and `psa_asymmetric_decrypt()`, `psa_get_and_lock_transparent_key_slot_with_policy()` is called to check if the key is transparent. The check is incorrect, it always fails in the case of opaque driver. The commit replaced `psa_get_and_lock_transparent_key_slot_with_policy` with `psa_get_and_lock_key_slot_with_policy`. Signed-off-by: Michael Zhao <michael.zhao@arm.com>
tgonzalezorlandoarm
added
bug
needs-review
gilles-peskine-arm
moved this from Mbed TLS 3.6 release
to Opaque driver support
in EPICs for Mbed TLS
minosgalanakis
moved this from Opaque driver support
to Mbed TLS 3.6 release
in EPICs for Mbed TLS
|
Closing as #8700 implements the same fix and it also adds testing for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
psa_asymmetric_encrypt()andpsa_asymmetric_decrypt(),psa_get_and_lock_transparent_key_slot_with_policy()is called to check if the key is transparent. The check is incorrect, it always fails in the case of opaque driver.The PR replaced
psa_get_and_lock_transparent_key_slot_with_policywithpsa_get_and_lock_key_slot_with_policy.Fixes 8461
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")