Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 3.6: Fix compilation when memcpy() is a function-like macro #9000

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Backport 3.6: Fix compilation when memcpy() is a function-like macro #9000

merged 1 commit into from
Apr 9, 2024

Conversation

tom-cosgrove-arm
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm commented Apr 2, 2024 •
edited by paul-elliott-arm
Loading

Fixes #8994

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

@tom-cosgrove-arm
Fix compilation of ssl_tls13_generic.c when memcpy() is a function-li…
b32d7ae 
…ke macro

Fixes Mbed-TLS#8994

Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
@tom-cosgrove-arm tom-cosgrove-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review component-tls13 priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Apr 2, 2024
@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Apr 2, 2024
Merged
4 tasks
@risicle
Copy link

risicle commented Apr 3, 2024

Works for us @ NixOS/nixpkgs#300629, nixos x86_64 & macos 12 x86_64 (building for SDK 10.12)

@tom-cosgrove-arm tom-cosgrove-arm changed the base branch from development to mbedtls-3.6 April 4, 2024 08:33
gilles-peskine-arm
gilles-peskine-arm approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (like #8999 (review)).

@gilles-peskine-arm gilles-peskine-arm added this to To Do in Roadmap Board for Mbed TLS via automation Apr 8, 2024
Roadmap Board for Mbed TLS automation moved this from To Do to Has Approval Apr 8, 2024
paul-elliott-arm
paul-elliott-arm approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport

@paul-elliott-arm paul-elliott-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review needs-ci Needs to pass CI tests labels Apr 8, 2024
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Apr 9, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 974006b Apr 9, 2024
6 checks passed
Roadmap Board for Mbed TLS automation moved this from Has Approval to Done Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@paul-elliott-arm paul-elliott-arm paul-elliott-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-tls13 priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap Board for Mbed TLS
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: memcpy(): too few arguments provided to function-like macro invocation
4 participants
@tom-cosgrove-arm @risicle @gilles-peskine-arm @paul-elliott-arm