-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quick links to change avatar and cover when viewing your own profile #206
Conversation
if viewing your own profile, clicking on your avatar or cover will bring you to the page to change them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, verified it works as expected.
Ow btw... This now only works when you are on profile overview page. Let's say I'm on a sub-page like profile comments or profile followers, this quick links will NOT appear.. |
I think that was 100% my intention, I don't think they should appear everywhere. Only for users that click the profile link expecting it to be a way to change their avatar. I might be misunderstanding, which routes are those? |
ok so besides |
following up from matrix convo, these routes are likely gaining the avatar / cover soon, but they don't on main yet. once it is I'll do a followup to add it to those routes as well |
if viewing your own profile, clicking on your avatar or cover will bring you to the page to change them
viewing someone else's profile does not show this link
(if I do show pointer, it won't show labels, if I do selection, it won't show pointer... just trust me the pointer is over avatar and cover where the label appears. there is a slight no-click zone to the right of the avatar due to the HTML element spacing, but I feel like the cover is a large enough target that users can click anywhere else)
related #69
not sure if it completely solves what @TheVillageGuy wanted to see, but this was one of my suggestions to help, as I feel it's fairly common to have this flow (you can see it here on github if you go to your profile, hovering over your avatar if you have one says "Change your avatar" (I wonder why they went with your rather than my 馃 ) and clicking that just directs you to the settings page