Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postmill to credits #211

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add postmill to credits #211

merged 1 commit into from
Nov 6, 2023

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Nov 6, 2023 •
edited

Missing credit to Postmill.

@melroy89 melroy89 added the documentation Improvements or additions to documentation label Nov 6, 2023
nobodyatroot
nobodyatroot approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@nobodyatroot nobodyatroot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, should be credited since several classes are lifted verbatim. And I think the code blocks in question have already been properly credited with the zlib license attribution.

@melroy89 melroy89 merged commit 679fa54 into main Nov 6, 2023
6 checks passed
@melroy89 melroy89 deleted the fixup-the-postmill-credits branch November 6, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodyatroot nobodyatroot nobodyatroot approved these changes

@e-five256 e-five256 e-five256 approved these changes

@BentiGorlich BentiGorlich Awaiting requested review from BentiGorlich

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@melroy89 @nobodyatroot @e-five256