Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sidebar labels for new loc token #223

Merged
merged 1 commit into from
Nov 8, 2023
Merged

update sidebar labels for new loc token #223

merged 1 commit into from
Nov 8, 2023

Conversation

e-five256
Copy link
Member

minor change, it looks like the translations were changed to subscription_sidebar_pop_out_left and subscription_sidebar_pop_out_right but the aria-label fields were left with the loc token subscription_sidebar_pop_out which does not exist

melroy89
melroy89 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Oopsy.

@e-five256 e-five256 merged commit 19f10be into main Nov 8, 2023
6 checks passed
@e-five256 e-five256 deleted the e5/sidebar-popout-translation branch November 8, 2023 01:33
@e-five256 e-five256 added bug Something isn't working frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melroy89 melroy89 melroy89 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@e-five256 @melroy89