Fix returning deleted admin

[BentiGorlich]

• the findAdmin method didn't filter for isDeleted, yet

Fix #67

[e-five256]

I know I'm late but I wonder why this didn't have a limit applied to it 🤔

[BentiGorlich]

I mean how many admins will an instance have :D
I'd say most instances are running with exactly one admin

[nobodyatroot]

hmm, i wonder what happens where there's more than 1, though... it might hose whatever is expecting only 1 like assigning a magazine owner? you're probably right about there usually only being 1 admin, but these edge cases might come back to bite later.

[e-five256]

It's not important, I just feel like if you already know the limitations you expect, it's good to declare, so I might want to add ->setMaxResults(1) to this or something, but also like I said not important

this is fine, the function always returns 1 result, the sql might just return more rows than you use, really not a big deal

[TheVillageGuy]

I mean how many admins will an instance have :D I'd say most instances are running with exactly one admin

Mine has three

[BentiGorlich]

well it just takes the first onw, so the edge case is kinda solved. The whole owner thing justneedstobe removed... Maybe we could say the mod that has been a mod the longest is the "owner", but I digress 😅 Am 11. November 2023 01:39:15 MEZ schrieb debounced ***@***.***>:

…

@nobodyatroot commented on this pull request. > ->getQuery() - ->getResult()[0]; hmm, i wonder what happens where there's more than 1, though... it might hose whatever is expecting only 1 like assigning a magazine owner? you're probably right about there usually only being 1 admin, but these edge cases might come back to bite later. -- Reply to this email directly or view it on GitHub: #243 (comment) You are receiving this because you modified the open/close state. Message ID: ***@***.***>