Kbin sync 9 #251
Merged
Kbin sync 9 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed-on: https://codeberg.org/Kbin/kbin-core/pulls/1227 Co-authored-by: Ernest Wiśniewski <ernestwisniewski2@gmail.com> Co-committed-by: Ernest Wiśniewski <ernestwisniewski2@gmail.com>
Reviewed-on: https://codeberg.org/Kbin/kbin-core/pulls/1229 Co-authored-by: Ernest Wiśniewski <ernestwisniewski2@gmail.com> Co-committed-by: Ernest Wiśniewski <ernestwisniewski2@gmail.com>
melroy89
added
frontend
e-five256
reviewed
Nov 12, 2023
|
Ran the PR as-is overnight and don't see any issues. |
nobodyatroot
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Looks good to me, also just re-evaluated with @e-five256 's merge. No issues.
|
I was also running it for 24 hours on kbin.melroy.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.url) if present otherwise use the thread title (e.title)Note: For now still skipping the user visibility where clauses.
PR:
OUT OF SCOPE:
Co-committed-by: Ernest Wiśniewski ernestwisniewski2@gmail.com