Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to create a sitewide notification below the header #256

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

nobodyatroot
Copy link
Member

Until now there hasn't been a way for admins to make site wide announcements to notify users of system maintenance or other serious news. This PR adds a notification bar below the header only if an announcement message has been set.

Screenshot 2023-11-13 150225

I didn't want to make a separate admin panel tab for it, so it's under the pages tab for now... our admin panel needs some serious TLC anyway.

I've also fixed a bug in the other the admin pages where once something is set you were unable to clear it/set it to null again without a 500 error being generated.

@nobodyatroot nobodyatroot added the enhancement New feature or request label Nov 13, 2023
@melroy89
Copy link
Member

I didn't want to make a separate admin panel tab for it, so it's under the pages tab for now...

I understand, but pages isn't really the correct place either I think, because it's not a page (nor the template component is stored in the page folder). What about putting it under Settings tab?

@melroy89 melroy89 self-requested a review November 13, 2023 21:20
@nobodyatroot
Copy link
Member Author

I didn't want to make a separate admin panel tab for it, so it's under the pages tab for now...

I understand, but pages isn't really the correct place either I think, because it's not a page (nor the template component is stored in the page folder). What about putting it under Settings tab?

That works too, I'll make that adjustment.

@nobodyatroot
Copy link
Member Author

so that settings page is a little more tricky than i thought... im not seeing an easy way to port over what i did without reworking a bunch of stuff in there. the settings page also mostly consists of things we have env vars assigned to... so we can keep this PR open if you want to take a crack at fixing what i did or we can make a follow on PR to adjust this and add the twig cache + whatever else needs fixing.

Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah fine for now.

@melroy89
Copy link
Member

.. Assuming it doesn't hurt performance. . ;P

@nobodyatroot nobodyatroot merged commit 66d3ac4 into main Nov 14, 2023
7 checks passed
@nobodyatroot nobodyatroot deleted the debounced/admin_notice branch November 14, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants