Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide nsfw magazine icons for logged out users, blur on mag sub/block pages #265

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

e-five256
Copy link
Member

@e-five256 e-five256 commented Nov 14, 2023

hide nsfw magazine icons for logged out users, this is consistent with how we currently handle entries. we discussed adding an admin option to allow enabling nsfw for logged out users, but that would require a bunch more work, so seemed like it could be, once again, another followup

blur magazine subscriptions (in user page or user settings page) and magazine blocks (in user settings)

this also adds the 18+ danger badge to subscription and block pages. opinions welcome if this is bad. The information isn't really hidden if you just go to the magazine, but if users make their subs public and there are nsfw mags in there, it's obvious now

another nsfw followup for #254

in my previous PR I had said the sub/block components didn't have nsfw info. Then I slept on it and realized, wait, how the heck would it have icon, there's no way that's in the sub/block table surely. I just misread the components, they have the info

magazine icon being hidden while logged out images

image
image
image
image
image

magazine sub and block icon being blurred out for user while logged in

image
image

blur magazine subscriptions and magazine blocks
@e-five256 e-five256 added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Nov 14, 2023
Copy link
Member

@nobodyatroot nobodyatroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for continuing to improve this!

@e-five256 e-five256 merged commit ef2c2a6 into main Nov 15, 2023
7 checks passed
@e-five256 e-five256 deleted the e5/mag-block-sub-blur branch November 15, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants