Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove copy pasted vote up class on downvote button #276

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

e-five256
Copy link
Member

@e-five256 e-five256 commented Nov 18, 2023

was browsing the DOM, as one does, and noticed the downvote buttons have the class vote__up. don't think it does anything, the rules are on .vote__up button and .vote__down button (this would be button.vote__up) so looks like it was just erroneously copy pasted (the upvote button has no classes)

@e-five256 e-five256 added the bug Something isn't working label Nov 18, 2023
@e-five256 e-five256 merged commit 6812e71 into main Nov 18, 2023
7 checks passed
@e-five256 e-five256 deleted the e5/downvote-upvote-class branch November 18, 2023 01:34
@e-five256 e-five256 added the low priority does not impact production code label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority does not impact production code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants