Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment URL twig render, missing user object #278

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

nobodyatroot
Copy link
Member

@nobodyatroot nobodyatroot commented Nov 18, 2023

Attempts to open comment URL directly results in 500 because twig render was not being passed user object, PR adds user object

image

image

@nobodyatroot nobodyatroot added the bug Something isn't working label Nov 18, 2023
e-five256
e-five256 previously approved these changes Nov 18, 2023
@e-five256 e-five256 dismissed their stale review November 18, 2023 21:38

needs to be added to callers

@nobodyatroot nobodyatroot merged commit 6fa52ab into main Nov 18, 2023
7 checks passed
@nobodyatroot nobodyatroot deleted the fix_comment_open_url branch November 18, 2023 22:05
@melroy89
Copy link
Member

melroy89 commented Nov 19, 2023

@nobodyatroot getEntryCommentPageResponse is that now not just returning a empty user object? I miss the get call that fills the $user. Right?

@nobodyatroot
Copy link
Member Author

getEntryCommentPageResponse

you mean this?

$user = $this->getUserOrThrow();
$criteria = new EntryCommentPageView($this->getPageNb($request));
$criteria->entry = $entry;

return $this->getEntryCommentPageResponse('entry/comment/edit.html.twig', $user, $criteria, $form, $request, $comment);

in src/Controller/Entry/Comment/EntryCommentEditController.php and src/Controller/Entry/Comment/EntryCommentCreateController.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants