Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image post processing event hook #287

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

asdfzdfj
Copy link
Contributor

@asdfzdfj asdfzdfj commented Nov 21, 2023

  • refactored/rearranged findOrCreateFrom{Path,Upload} function a bit, ended up doing in a similar way I have done in ApHttpClient.
  • added ImagePostProcessEvent for processing image files before being saved to storage.

this is in preparation for adding image exif cleaner and allows for different cleaning modes for uploaded and external images (#263), this one needed to be merged first

Copy link
Member

@e-five256 e-five256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as long as @BentiGorlich has no further concerns

@BentiGorlich
Copy link
Member

I want to try it later today on my machine and if there are no problems I am fine with it

@asdfzdfj asdfzdfj force-pushed the new/image-post-process-event-hook branch from f148d58 to fafab5c Compare November 24, 2023 08:22
adding ImagePostProcessEvent for processing image files
downloaded/uploaded before storing images.

this is in preparation for adding image exif cleaner and allow for
different cleaning modes for uploaded and external images
@asdfzdfj asdfzdfj force-pushed the new/image-post-process-event-hook branch from fafab5c to 028041a Compare November 25, 2023 04:22
@asdfzdfj asdfzdfj merged commit fd632c5 into MbinOrg:main Nov 25, 2023
7 checks passed
@melroy89 melroy89 added enhancement New feature or request backend Backend related issues and pull requests labels Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants