remote magazines - remove ability to apply for moderator or owner #308
Conversation
remove ability to apply for moderator and apply for ownership of remote magazines do not return remote magazines in the find abanadoned call sync apply for moderator button filters to the moderator sidebar add missing reject text on moderator requests page
e-five256
added
the
frontend
| @@ -555,6 +555,7 @@ public function findAbandoned(int $page = 1): PagerfantaInterface | |||
| ->where('mod.magazine IS NOT NULL') | |||
| ->andWhere('mod.isOwner = true') | |||
| ->andWhere('u.lastActive < :date') | |||
| ->andWhere('m.apId IS NULL') | |||
There was a problem hiding this comment.
@nobodyatroot mentioned once that remote mags were showing up in the list of abandoned magazines allowing users to apply for ownership. Rather than add magazine.apId is same as null to all buttons, I chose instead to just make it so remote magazines do not get returned from this call
There was a problem hiding this comment.
I also need to change isAbandoned() it looks like, otherwise the button still appears on the moderator page
edit: done
the display is different when there are open requests to become a mod, it displays a count, so it seems useful for current mods to see this apply for mod button even though they already are one
fix moderators list component being included when no moderators
| {{ pagerfanta(moderators, null, {'pageParameter':'[p]'}) }} | ||
| {% endif %} | ||
| {% if not moderators|length %} | ||
| {% if moderators|length %} |
There was a problem hiding this comment.
found this while testing, list was being included even when no moderators, which is how we display kbin mags now similar to lemmy
images
before
after
| @@ -54,7 +54,7 @@ | |||
| <button type="submit" | |||
| class="btn btn__secondary" | |||
| title="{{ 'reject'|trans }}"> | |||
| <i class="fa-solid fa-ban"></i> | |||
| <i class="fa-solid fa-ban"></i> {{ 'reject'|trans }} | |||
There was a problem hiding this comment.
Is the {{ 'reject'|trans }} doing something on this line?
There was a problem hiding this comment.
it adds the label after the icon to make it clearer what it's for.
oh, whoops, it should also be in a <span>; my bad, one second (added)
before
after
followup to #235