changed textarea backtick wrapping to only act on selections #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-five256
reviewed
Nov 28, 2023
e-five256
reviewed
Nov 28, 2023
e-five256
previously approved these changes
Nov 28, 2023
- changed the backtick button in comment box to only add enclosing backticks on selected text, as I find the current behavior utterly irritating especially when trying to type a fenced code block - activates the selection wrapping for single/double quote, and tilde - activates the selection wrapping for underscore and asterisk, but it will cycle between 0,1,2 wrapping characters like this: `word` -> `*word*` -> `**word**` -> `word` -> ...
asdfzdfj
force-pushed
the
new/textarea-key-wrap-selection
branch
from
d5f6d40
to
2289918
Compare
e-five256
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
in firefox, this seems to be working fine, in my chromium browser, selecting via keyboard is fine, selecting via click and dragging is fine, but if I double click on a word for some reason it deletes 1 character to the left as well and changes the selection area. I don't think that's a reason to hold this up as it seems like an improvement overall, and it's possible chromium doesn't correctly mimic google chrome anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this change is largely due to my personal opinion. if it also works out for you then great. if not, feel free to leave some suggestions
like this:
word->*word*->**word**->word-> ...