Changes to report links and magazine report fix #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move pending to far left and all to far right remove non-functional filter fix duplicate where clause
e-five256
added
bug
e-five256
commented
Nov 30, 2023
| @@ -64,33 +65,4 @@ | |||
| </a> | |||
| </li> | |||
| </menu> | |||
| {% if is_route_name('magazine_panel_reports') %} | |||
There was a problem hiding this comment.
this was unfunctional as far as I could tell. I didn't even notice it had existed before, but clicking the links does nothing ( I failed to get the label in the screenshot but it says "Filter by time" which isn't related to the menu items either)
nobodyatroot
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the default page landing on all reports to be fairly useless, generally I think you're going to care about pending reports rather than all reports ever made. Instead of changing the default in routing (which I think would change say
/reportsto be pending and/reports/allto exist which might break history), I changed the links that go to reports to go to/pendinginstead. I also rearranged the menu items to be: Pending, Approved, Rejected, AllThis also fixes a 500 error when viewing magazine reports for accepted/pending/rejected that I noticed while making this change