Reject user actions when banned #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in places where magazine ban status is also checked for entry, post, comment managers
Closed
asdfzdfj
pushed a commit
to asdfzdfj/mbin
that referenced
this pull request
Dec 11, 2023
check user ban status in places where magazine ban status is also checked for entry, post, comment managers
asdfzdfj
pushed a commit
to asdfzdfj/mbin
that referenced
this pull request
Dec 17, 2023
check user ban status in places where magazine ban status is also checked for entry, post, comment managers
asdfzdfj
pushed a commit
to asdfzdfj/mbin
that referenced
this pull request
Dec 25, 2023
check user ban status in places where magazine ban status is also checked for entry, post, comment managers
asdfzdfj
pushed a commit
to asdfzdfj/mbin
that referenced
this pull request
Dec 26, 2023
check user ban status in places where magazine ban status is also checked for entry, post, comment managers
asdfzdfj
pushed a commit
to asdfzdfj/mbin
that referenced
this pull request
Dec 30, 2023
check user ban status in places where magazine ban status is also checked for entry, post, comment managers
melroy89
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In places where user actions are rejected for magazine ban status, also check user ban status
/kbin made a similar change here https://codeberg.org/Kbin/kbin-core/commit/856c4af6e3cfe712d2de938348cea9e5ed48fa6d#diff-8a618e8d5292d99867ab274be47e07a82c5b7ed4 which made me realize we have the same issue, create entry / post / entry comment / post comment don't check user is banned status where they check magazine ban status
this adds the check, as well as adds it to permission checks on voters. That might be overkill, ideally the banned user should be logged out, but it also didn't feel necessarily wrong to safeguard if for any reason they didn't get logged out. willing to go either way on this
hoping to verify that banning a remote account doesn't stop content from being federated in on main, but does after this change