Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move menu's to dedicated twig templates + small refactoring #335

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Dec 5, 2023

Cherry-picking again only changes I would like from RTR#9v2. I do not sync the spam protection, in fact in future commits this feature is removed again from kbin. It just doesn't make sense. I also will not sync the removal of this view counter (we keep using this feature).

  • Move menu's to it's own dedicated twig templates for easier reuse (bonus: also makes it easier to sync other future changes)
  • Small refactor admin ban to top of method
  • Small refactoring with unit-tests

@melroy89 melroy89 merged commit 8a9b9b9 into main Dec 5, 2023
7 checks passed
@melroy89 melroy89 deleted the rtr9_v2_sync branch December 5, 2023 23:27
@melroy89 melroy89 added enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end backend Backend related issues and pull requests testing Unit/Functional/Integration test issues and pull requests labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end testing Unit/Functional/Integration test issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants