Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing a Project Info service (updates useragent version as well) #336

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Introducing a Project Info service (updates useragent version as well) #336

merged 3 commits into from
Dec 7, 2023

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Dec 6, 2023 •
edited

  • Introduce a Project Info service
  • Use this service to also update the user-agent string version (iso of 0.1)

@melroy89 melroy89 added enhancement New feature or request activitypub ActivityPub related issues backend Backend related issues and pull requests labels Dec 6, 2023
@nobodyatroot
Copy link
Member

nobodyatroot commented Dec 6, 2023 •
edited

Could we make a "getter" from src/Factory/ActivityPub/NodeInfoFactory.php so this isn't hardcoded? I can see this being easy to forget unless we have a release checklist somewhere. Or we move the version constant somewhere else?

@melroy89 melroy89 changed the title Update useragent string version Introducing a Project Info service (updates useragent version as well) Dec 7, 2023
@melroy89
Copy link
Member Author

melroy89 commented Dec 7, 2023

Could we make a "getter" from src/Factory/ActivityPub/NodeInfoFactory.php so this isn't hardcoded? I can see this being easy to forget unless we have a release checklist somewhere. Or we move the version constant somewhere else?

Agreed. We should have this done this much earlier already. I introduce a Symfony service for this.

nobodyatroot
nobodyatroot previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@nobodyatroot nobodyatroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@melroy89
Copy link
Member Author

melroy89 commented Dec 7, 2023 •
edited

Looks good to me!

Except I missed this ;)

⏰ 🔔 🔥 🚒

@nobodyatroot
Copy link
Member

Looks good to me!

Except I missed this ;)

Eh, minor detail. :-P

@melroy89
Copy link
Member Author

melroy89 commented Dec 7, 2023

U sure now ;P?

@melroy89 melroy89 merged commit 97a189d into main Dec 7, 2023
7 checks passed
@melroy89 melroy89 deleted the update_ua branch December 7, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodyatroot nobodyatroot nobodyatroot approved these changes

Assignees
No one assigned
Labels
activitypub ActivityPub related issues backend Backend related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@melroy89 @nobodyatroot