using blurhash for obscuring sensitive image #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdfzdfj
added
the
please review
asdfzdfj
force-pushed
the
new/blurhash-sensitive-image
branch
from
98aad46
to
fc64b23
Compare
melroy89
previously approved these changes
Dec 11, 2023
melroy89
reviewed
Dec 11, 2023
asdfzdfj
force-pushed
the
new/blurhash-sensitive-image
branch
from
76ba98e
to
1af8ce4
Compare
asdfzdfj
force-pushed
the
new/blurhash-sensitive-image
branch
from
1af8ce4
to
22dd43b
Compare
|
Hopefully this is the last branch that is outside of this repo, since it really makes it much harder to test if I want to switch branches. |
melroy89
approved these changes
Dec 12, 2023
replaced blur filter usage over sensitive image to obscure the image with blurhash image, using hidden checkbox + css to control visibility and buttons to switch between show and hide sensitive image for image attachment in post and comments, hide the sensitive image by putting blurhash image over along with the show button for entry thumbnail, it works a bit differently: - the sensitive image is hidden by hiding the main image and show existing blurhash background image instead - due to space constraints, the show/hide button is icons only, additionally when in mobile layout and compact view, the hide button will not be shown after the image is revealed
- attach lightbox to image/article entries but not for link/video entries - link/video entries should also have `rel` set
asdfzdfj
force-pushed
the
new/blurhash-sensitive-image
branch
from
81cf91b
to
8c73c08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced blur filter usage over sensitive image to obscure the image with blurhash image, using hidden checkbox + css to control visibility and buttons to switch between show and hide sensitive image
for image attachment in post and comments, hide the sensitive image by putting blurhash image over along with the show button
for entry thumbnail, it works a bit differently:
currently looks something like this: