Fix 2 errors when announcing anything #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BentiGorlich
commented
Dec 19, 2023
BentiGorlich
commented
- lemmy is not able to handle announce posts where the object is a url reference -> just put the whole object there
- we got errors when announcing posts that are from another instance, because we tried to sign them with the private key of the actor which is only available for local users
- lemmy is not able to handle announce posts where the object is a url reference -> just put the whole object there - we got errors when announcing posts that are from another instance, because we tried to sign them with the private key of the actor which is only available for local users
BentiGorlich
added
bug
melroy89
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.