Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time filter display #360

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Update time filter display #360

merged 3 commits into from
Dec 19, 2023

Conversation

e-five256
Copy link
Member

@e-five256 e-five256 commented Dec 19, 2023

  • change time filter to show currently selected option when on larger display than mobile
  • change icon from asc,desc icon to clock
  • move time filter first

not sure about other people but I found the time filter very hidden and confusing
image

the middle option here is time, but it uses an ascending / descending icon and doesn't really indicate what it's for or doing

this changes the bar to look like this:
image

showing the currently selected option, moved it to be the first as it seemed more important than filtering entry types

another look:
image

showing dropdown:
image

microblog:
image

on mobile it will not show the label to save room:
image

change icon from asc,desc icon to clock
move time filter first
@e-five256 e-five256 added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Dec 19, 2023
@@ -112,7 +92,8 @@
<button
aria-label="{{ 'filter_by_type'|trans }}"
title="{{ 'filter_by_type'|trans }}"><i
class="fa-solid fa-filter"></i> {{ 'filter_by_type'|trans }}</button>
Copy link
Member Author

@e-five256 e-five256 Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it saying "Filter by time" "Filter by type" "Change view". They were doing it at font-size 0 so it was never displayed visually. I am wondering if this was for screen readers; but according to google, which may or may not be accurate as it has changed a lot over the years, setting to font size 0 isn't recommended (just as display none would also be skipped over). If it is an issue, we'd have it in lots of other places like federation / settings sidebar as those also don't have any text hidden on them

@@ -28,15 +28,6 @@
}
}

&__layout{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seemed like this was trying to do something to keep the border radius only effecting the right most option the layout before was

  • menu
    • li
  • menu
    • li
    • li

I changed this to just be one menu with 3 lis and made the css selector simpler with :not last, :last so it's always accurate no matter how many items exist

@e-five256 e-five256 merged commit f091878 into main Dec 19, 2023
7 checks passed
@e-five256 e-five256 deleted the e5/time-clock-display branch December 19, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants