-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update time filter display #360
Conversation
change icon from asc,desc icon to clock move time filter first
@@ -112,7 +92,8 @@ | |||
<button | |||
aria-label="{{ 'filter_by_type'|trans }}" | |||
title="{{ 'filter_by_type'|trans }}"><i | |||
class="fa-solid fa-filter"></i> {{ 'filter_by_type'|trans }}</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it saying "Filter by time" "Filter by type" "Change view". They were doing it at font-size 0
so it was never displayed visually. I am wondering if this was for screen readers; but according to google, which may or may not be accurate as it has changed a lot over the years, setting to font size 0
isn't recommended (just as display none
would also be skipped over). If it is an issue, we'd have it in lots of other places like federation / settings sidebar as those also don't have any text hidden on them
@@ -28,15 +28,6 @@ | |||
} | |||
} | |||
|
|||
&__layout{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seemed like this was trying to do something to keep the border radius only effecting the right most option the layout before was
menu
li
menu
li
li
I changed this to just be one menu
with 3 li
s and made the css selector simpler with :not last
, :last
so it's always accurate no matter how many items exist
not sure about other people but I found the time filter very hidden and confusing
the middle option here is time, but it uses an ascending / descending icon and doesn't really indicate what it's for or doing
this changes the bar to look like this:
showing the currently selected option, moved it to be the first as it seemed more important than filtering entry types
another look:
showing dropdown:
microblog:
on mobile it will not show the label to save room: