Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix js error when clicking home button on mobile sidebar #383

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

e-five256
Copy link
Member

prior to this, clicking on the home button in the sidebar generated the error:

Error invoking action "click->options#home"
Error: Action "click->options#home" references undefined method "home"

this is because no home action exists in https://github.com/MbinOrg/mbin/blob/main/assets/controllers/options_controller.js
the button still functioned, however, so functionally this changes nothing, just wanted to clean up the js exception

@e-five256 e-five256 added the low priority does not impact production code label Dec 25, 2023
@e-five256 e-five256 merged commit 1880e54 into main Dec 25, 2023
7 checks passed
@e-five256 e-five256 deleted the e5/home-js-error branch December 25, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority does not impact production code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants