Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move footer information into sidebar #385

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Move footer information into sidebar #385

merged 6 commits into from
Jan 8, 2024

Conversation

e-five256
Copy link
Member

@e-five256 e-five256 commented Dec 25, 2023

This was originally suggested by @lilfade and others

Purpose:

Remove the footer from the site and add the information into the sidebar

Reasoning:

  • Reaching the footer with infinite scrolling enabled was near impossible, and completely impossible on mobile (kbin issue on the matter)
  • To combat that, @simonrcodrington added the footer to the sidebar on mobile, though we did see some issues with that Mobile sidebar footer in light mode not readable #66 and potentially duplicated in some cases
  • There are plenty of examples of not having a footer for social media sites, our peer mastodon for instance, does not have a footer https://mastodon.social nor activitypub social hub https://socialhub.activitypub.rocks/c/welcome/1 (admittedly this is a bit flimsy, I'm sure for every site that doesn't have one you could link one that does, lemmy for instance does but does not have infinite scrolling (unless that's locked behind having an account) (edit: perhaps you could say anything with infinite scrolling tends to not. mlmym's lemmy ui, mastodon, activity pub have infinite scrolling and no footer, lemmy ui does not have infinite scrolling and does have a footer)

Changes:

This is what the information in the sidebar currently looks like, though very much up for feedback as it's a lot of information condensed

image

bottom of the page now (it's what you'd expect, no footer)

image

image of mastodon legal sidebar for comparison

image

main callouts are:

  • added current mbin version from project info service
  • removed links to create new posts, those were all duplicated as they already exist in the header, same for list all magazines
  • removed the © current year thing, couldn't really find any examples of anyone else doing that, not sure it provides a legal defense, but there is a terms of use already. though I remain not a lawyer
  • rss feels a bit out of place, maybe it should go in the header instead? I've seen it there some times, or maybe it's fine as is, lang switch similarly might not be in the best spot

@e-five256 e-five256 added needs feedback Requires a greater consensus to make an informed decision frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Dec 25, 2023
@e-five256 e-five256 marked this pull request as ready for review January 6, 2024 00:34
@melroy89
Copy link
Member

melroy89 commented Jan 6, 2024

This also solves the endless scroll feaure dilemma and workarounds. I love it. Most social media websites do not have a footer at the bottom for a good reason.

@nobodyatroot
Copy link
Member

Should we turn infinite scroll on by default with this change? Sometimes I wonder how many users actually go through the effort to look at all the options available in the settings menu...

@e-five256
Copy link
Member Author

I think it's worth discussing if we want to make that the default for the software, but maybe not part of this specific change / pr. I would like to get more admin settings for all the defaults set up soonish

nobodyatroot
nobodyatroot previously approved these changes Jan 6, 2024
@asdfzdfj
Copy link
Contributor

asdfzdfj commented Jan 7, 2024

the rss button could probably be moved to upper section with about/faq/rules/etc., and give it a full label ("RSS Feed" or whatever, icons optional), while keeping the interface language selector where it was, either centered or stretched to full width

@e-five256
Copy link
Member Author

this is what it looks like now

image

@nobodyatroot nobodyatroot self-requested a review January 8, 2024 00:53
@e-five256
Copy link
Member Author

@asdfzdfj does the change look acceptable to you?

Copy link
Contributor

@asdfzdfj asdfzdfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asdfzdfj does the change look acceptable to you?

good enough for me

@e-five256 e-five256 merged commit 2884818 into main Jan 8, 2024
7 checks passed
@e-five256 e-five256 deleted the e5/remove-footer branch January 8, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end needs feedback Requires a greater consensus to make an informed decision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants