announce likes #420
Merged
announce likes #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
enhancement
BentiGorlich
force-pushed
the
ap-announce-likes
branch
2 times, most recently
from
7180ae8
to
9f8884d
Compare
if a local magazine receives a like from a remote user it will announce it to all the followers of the magazine - create the `DeliverManager` to avoid code duplicates - also avoid sending a message twice to the same inbox
In an edge case the like message did not get sent to the remote instance which is hosting the magazine. This case is: Instance A is hosting Magazine M, instance B has users C and D. C creates an entry in M and D likes the post. Because the author of the post is local the like would not get sent to the remote instance which is supposed to get it and then announce it
BentiGorlich
force-pushed
the
ap-announce-likes
branch
from
9f8884d
to
c4d8902
Compare
nobodyatroot
previously approved these changes
Jan 16, 2024
melroy89
approved these changes
Jan 21, 2024
andrewmoise
pushed a commit
to andrewmoise/mbin
that referenced
this pull request
Jan 24, 2024
Co-authored-by: debounced <35878315+nobodyatroot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a local magazine receives a like from a remote user it will announce it to all the followers of the magazine
I started a thread about it if anyone wants more context: https://gehirneimer.de/m/Mdev@kbin.run/t/151312/Your-thoughts-on-federating-likes-upvotes