exposing jsonld contexts as a separate route #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this problem was pointed out by piefed author (https://join.piefed.social/2023/11/18/you-can-ignore-json-ld/): - for the most part, barely any application actually bothers to parse AP objects as json-ld and just treat it as some shaped json - for some type of messages, the overhead of sending json-ld `@contexts` is bigger than what the message is about, combined with the above point then it's just a waste of data transfers added a route that returns extra ActivityPub json-ld contexts and uses it as an extra `@context` in emitted AP objects a good tradeoff between not wasting data transferring unneeded contexts while still being able parse as a valid json-ld if needed be this solution is more or less shamelessly replicated from Akkoma/Pleroma, thanks for that.
nobodyatroot
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this problem was pointed out by piefed author
(https://join.piefed.social/2023/11/18/you-can-ignore-json-ld/):
@contextsis bigger than what the message is about, combined with the above point then it's just a waste of data transfersadded a route that returns extra ActivityPub json-ld contexts and uses it as an extra
@contextin emitted AP objectsa good tradeoff between not wasting data transferring unneeded contexts while still being able parse as a valid json-ld if needed be
this solution is more or less shamelessly replicated from Akkoma/Pleroma, thanks for that.