Do not show debug messages in prod #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melroy89
referenced
this pull request
Jan 14, 2024
I thought someone already hooked the app log to docker logs but apparently not so here goes: - mount the log directory within `php`, `messenger` and `messenger_ap` services to host `storage/logs` directory for easier access and more persistent log storage, so it doesn't get washed away when recreating containers while trying to debug something - adjust logging to also send logs to stderr, which will be output to docker logs, and can be viewed using `docker logs`, `docker compose logs` and the like for bare metal setups, this stderr log should already be discarded by php-fpm (see php-fpm option `catch_workers_output`) - add extra instructions and mentions in the docker guide about logging, as introduced by this change
BentiGorlich
approved these changes
Jan 14, 2024
nobodyatroot
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production I do not want to see debug messages, the whole point of production is to minimize logging pollution and disk I/O towards log file(s). Only show error messages.
Ps. I tried to set it to
info, but that didn't work either, but setting the log level towarningsolved the problem.