-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to restrict sidebar sections to local only #435
Conversation
This is very minor, but it seems like we have been going with naming things |
To clarify, you're asking for new env vars to start with MBIN_ but leave the KBIN_ ones in tact, so we have a mix of both? |
Yea, that's what I ended up doing when adding the default_theme one most recently https://github.com/MbinOrg/mbin/blob/2bf67ceed54c889672c4e932b9fbfd6769a78de9/.env.example#L32C1-L33 (I agree it's confusing, but the other options have their cons as well. Probably not appropriate to add code that says kbin, and we can't easily switch everything that exists to mbin without lots of defensive fallback coding having to be added first) |
Just a head's up, I still plan on addressing the feedback on this PR but before that I'd like to change the behavior. I'd rather the random post and threads were from local magazines, regardless of whether the user was local. |
aside from my one final comment this appears fine to me, but I'm no expert, @melroy89 @nobodyatroot not sure if you two or anyone else has opinions, I tested this locally and not having the env var set doesn't cause any issues (I was kind of expecting it to need |
Co-authored-by: e-five <146029455+e-five256@users.noreply.github.com>
When enabled by an admin, this will make the random magazines, active people, random posts, and random threads only show the local items of those types. This does not affect the sections when looking at a specific community.