Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove forced line break on timestamps from sidebar components #437

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

e-five256
Copy link
Member

@e-five256 e-five256 commented Jan 15, 2024

this is a very opinionated change

there's a lot on unused space in the random components due to the large amount of space to the left of timestamps / magazine. To me it doesn't feel too cramped on a single line, there's still quite a lot of spacing to break up the descriptions from the post info, even on mobile, but if people think it's easier to read on multiple lines I don't mind closing this either

edit: I was also considering adding the user posting / avatar / magazine icon (based on display settings) but decided against it for now. I think username at least could be useful in some situations (I constantly see "10 minutes ago posted to random" thinking what could this possibly be, but then I go and see it was posted by "daily ferrets" and realize oh it's a picture of a ferret), but didn't want to overload the component

before:

desktop:
image
mobile:
image

after:

desktop:
image
mobile:
image

@e-five256 e-five256 added the low priority does not impact production code label Jan 15, 2024
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this makes it a bit smaller on the screen and make use of the space available.

@e-five256 e-five256 merged commit 74d151e into main Jan 15, 2024
7 checks passed
@e-five256 e-five256 deleted the e5/sidebar-time-display branch January 15, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority does not impact production code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants