small adjustment to textarea enclosure wrapping #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow tilde (`~`) to cycle up to 2 enclosures, although it looks like GFM allows strikethrough text to be written with just one (1) tilde, many place only use `~~` for marking strikethrough text, - remove delete execCommand when toggling enclosure, it mess with undo stack in a rather clunky way, and insertText generally overwrites selected texts if there's any
melroy89
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~) to cycle up to 2 enclosures, although it looks like GFM spec allows strikethrough text to be written with just 1 tilde, many place only allows 2 tildes (~~) for marking strikethrough textdeleteexecCommand when toggling enclosure, it mess with undo stack in a rather clunky way: what appears to be a single operation results in 2 undos, one that deletes the selected text and one for changing the enclosure. also theinsertTextcommand generally overwrites selected texts if there's any already