prune some likely unused ActivityPhp related code #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I hate dead code. I just check if I don't see any regression.. |
|
It seems to work fine. I still would like to run it a bit longer. |
asdfzdfj
force-pushed
the
rework/prune-unused-activityphp-code
branch
from
0211f72
to
4537c71
Compare
melroy89
approved these changes
Jan 17, 2024
this patch removes most of the files/constructs that was copied from landrok/ActivityPhp, overall federation functionality shouldn't change. there's a decent chunk of code that was copied from the ActivityPhp library into kbin/mbin, but they're barely used in the codebase. the closest I've seen it in active use is in Webfinger factory and even then it was modified to use our own service and didn't actually call out to the library
asdfzdfj
force-pushed
the
rework/prune-unused-activityphp-code
branch
from
4537c71
to
321e52c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch removes most of the files/constructs that was copied from landrok/ActivityPhp, overall federation functionality shouldn't change.
there's a decent chunk of code that was copied from the ActivityPhp library into kbin/mbin, but they're barely used in the codebase.
the closest I've seen it in active use is in Webfinger factory and even then it was modified to use our own service and didn't actually call out to the library