-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved logo's #443
Improved logo's #443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with it, however, please wait for others to approve as I was not at all involved in creating the Logo in the first place and the old and new version are both looking fine to me
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried my best to avoid value judgements but given the subject it's quite hard to completely eliminate them and I might unintentionally slips some here and there
still going to requesting changes as what happened to maskable PWA icons can be treated as a technical regression (see below for details)
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as outdated.
This comment was marked as outdated.
Nope.. I didn't 💀 .. I tried though.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'll let others chime in/approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some more of my 2c, @vintprox not sure if you're still around but I could use some second opinion here
the PWA safe region regiression is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
personally I still have some reservations but it's mostly value differences and nothing ultimately show-stopping so this should be good enough
mbin_logo_genesis.png