Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logo's #443

Merged
merged 24 commits into from
Jan 20, 2024
Merged

Improved logo's #443

merged 24 commits into from
Jan 20, 2024

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Jan 16, 2024

  • Improve logo ratio (as I stated here)
  • Improved overall image ratio (1:1), on the images without text
  • Improved text, just a bit more fancy pancy 8-)
  • Introduced an additional maskable logo (with 40% diameter safe-zone circle)
  • Improve logo consistency with all the logos, asset icons, favicon, og images, etc. So we just use the same logo across the board.
  • Remove old mbin_logo_genesis.png

image

@melroy89 melroy89 added enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Jan 16, 2024
BentiGorlich
BentiGorlich previously approved these changes Jan 17, 2024
Copy link
Member

@BentiGorlich BentiGorlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with it, however, please wait for others to approve as I was not at all involved in creating the Logo in the first place and the old and new version are both looking fine to me

@nobodyatroot

This comment was marked as resolved.

Copy link
Contributor

@asdfzdfj asdfzdfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried my best to avoid value judgements but given the subject it's quite hard to completely eliminate them and I might unintentionally slips some here and there

still going to requesting changes as what happened to maskable PWA icons can be treated as a technical regression (see below for details)

assets/images/sources/mbin-og.svg Show resolved Hide resolved
assets/images/sources/mbin-text.svg Show resolved Hide resolved
public/assets/icons/icon-512-maskable.png Show resolved Hide resolved
@melroy89

This comment was marked as abuse.

@melroy89

This comment was marked as outdated.

@melroy89
Copy link
Member Author

Fixed that as well.

Nope.. I didn't 💀 .. I tried though..

@melroy89 melroy89 changed the title Improved logo Improved logo's Jan 17, 2024
@melroy89 melroy89 added the please review I want to be sure what I did won't cause problems label Jan 17, 2024
nobodyatroot
nobodyatroot previously approved these changes Jan 17, 2024
Copy link
Member

@nobodyatroot nobodyatroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll let others chime in/approve.

Copy link
Contributor

@asdfzdfj asdfzdfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some more of my 2c, @vintprox not sure if you're still around but I could use some second opinion here

docs/images/mbin.png Show resolved Hide resolved
assets/images/sources/mbin-text.svg Show resolved Hide resolved
assets/images/sources/mbin-logo-maskable.svg Show resolved Hide resolved
@asdfzdfj asdfzdfj dismissed their stale review January 18, 2024 15:47

the PWA safe region regiression is fixed

Copy link
Contributor

@asdfzdfj asdfzdfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally I still have some reservations but it's mostly value differences and nothing ultimately show-stopping so this should be good enough

@melroy89 melroy89 merged commit 0d34114 into main Jan 20, 2024
7 checks passed
@melroy89 melroy89 deleted the update_logo branch January 20, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end please review I want to be sure what I did won't cause problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants