set default of local sidebar sections #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move out from env var similar to federated search
nobodyatroot
approved these changes
Jan 17, 2024
|
@thepaperpilot headsup if you were relying on setting the env var to true locally, you'll want to get it saved and written to the DB settings table before getting this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move out from env var similar to federated search
mentioned in #446 adding a new env var comes with the price of either breaking existing instance owners or defaulting, but the defaulting in symfony always appears to have a lot of issues, especially with non-string types like
ints andbools (e.g.Invalid env fallback in \"default:false:MBIN_SIDEBAR_SECTIONS_LOCAL_ONLY\")I think it might be best if we keep new settings to having sane defaults in php, and using the db as the source of truth for when set, and potentially deprecate the use of env var unless absolutely necessary (granted I added one for default theme, before realizing it wasn't a requirement to adding a new admin setting, potentially we could remove it and others)