use title instead of body for federated entry summary #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdfzdfj
force-pushed
the
fix/ap-entry-summary-use-title
branch
from
9f96c80
to
51304fd
Compare
melroy89
approved these changes
Feb 18, 2024
changed entries summary in AP representation to draw from title instead from body, this way the title will be shown along with 'show more' button in most of other fediverse software, which should feel more intuitive and avoids repeating the body twice
asdfzdfj
force-pushed
the
fix/ap-entry-summary-use-title
branch
from
51304fd
to
6acecee
Compare
andrewmoise
pushed a commit
to andrewmoise/mbin
that referenced
this pull request
Feb 20, 2024
changed entries summary in AP representation to draw from title instead from body, this way the title will be shown along with 'show more' button in most of other fediverse software, which should feel more intuitive and avoids repeating the body twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed entries summary in AP representation to draw from title instead from body, this way the title will be shown along with 'show more' button in most of other fediverse software, which should feel more intuitive and avoids repeating the body twice
this is what it looks like, current state on the left (Jerry's post), proposed patch on the right: