move service worker registration into main app bundle #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved service worker registration into main app bundle, and also deferred the service worker registration a bit as recommended by https://web.dev/articles/service-workers-registration#improving_the_boilerplate, though our service worker doesn't seems to be doing anything much. this removes 1 inline script block from base template
asdfzdfj
force-pushed
the
fix/service-worker-register-in-js
branch
from
bd3097f
to
5aceae8
Compare
melroy89
approved these changes
Feb 18, 2024
andrewmoise
pushed a commit
to andrewmoise/mbin
that referenced
this pull request
Feb 20, 2024
moved service worker registration into main app bundle, and also deferred the service worker registration a bit as recommended by https://web.dev/articles/service-workers-registration#improving_the_boilerplate, though our service worker doesn't seems to be doing anything much. this removes 1 inline script block from base template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved service worker registration into main app bundle, and also deferred the service worker registration a bit as recommended by https://web.dev/articles/service-workers-registration#improving_the_boilerplate, though our service worker doesn't seems to be doing anything much.
this removes 1 inline script block from base template