adjust tag matching to better handle some eastern scripts #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdfzdfj
force-pushed
the
fix/tag-matching-eastern-script
branch
from
58e8f0c
to
70b0550
Compare
melroy89
approved these changes
Feb 18, 2024
the current hashtags matching and normalizing works fine with latin scripts, but it often breaks when having to deal with e.g. Japanese hashtags, which can results in hashtags not being extracted properly or worse, the posts being dropped entirely the hashtags matching has beed extended to allow for more characters to match, and normalization process has been adjusted to better handle nonlatin script (e.g. Japanese, Thai) most of the process is a recreation of Mastodon hastags normalization process
asdfzdfj
force-pushed
the
fix/tag-matching-eastern-script
branch
from
70b0550
to
094535a
Compare
andrewmoise
pushed a commit
to andrewmoise/mbin
that referenced
this pull request
Feb 20, 2024
the current hashtags matching and normalizing works fine with latin scripts, but it often breaks when having to deal with e.g. Japanese hashtags, which can results in hashtags not being extracted properly or worse, the posts being dropped entirely the hashtags matching has beed extended to allow for more characters to match, and normalization process has been adjusted to better handle nonlatin script (e.g. Japanese, Thai) most of the process is a recreation of Mastodon hastags normalization process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current hashtags matching and normalizing works fine with latin scripts, but it often breaks when having to deal with e.g. Japanese hashtags, which can results in hashtags not being extracted properly or worse, the posts being dropped entirely
the hashtags matching has beed extended to allow for more characters to match, and normalization process has been adjusted to better handle nonlatin script (e.g. Japanese, Thai)
most of the process is a recreation of Mastodon hastags normalization process (see https://docs.joinmastodon.org/spec/activitypub/#Hashtag and the linked normalizer)