slightly fix object body extraction on set but empty body #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the object markdown body extraction method to return empty body if object's content properties is set to empty string the old body extracting condition could cause comments with empty body (but may have image attached) to be silently discarded
asdfzdfj
force-pushed
the
fix/md-body-extract-discarded-set-empty-body
branch
from
eb9c036
to
03f3904
Compare
nobodyatroot
approved these changes
Feb 24, 2024
melroy89
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the object markdown body extraction method to return empty body
''if object's content properties is set but to an empty stringthe old body extracting condition could cause comments with empty body (but may have image attached) to be silently discarded