Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use title in "related magazines" panel #554

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Use title in "related magazines" panel #554

merged 2 commits into from
Mar 7, 2024

Conversation

BentiGorlich
Copy link
Member

@BentiGorlich BentiGorlich commented Mar 5, 2024 •
edited

  • change the inline magazine component to use the title of the magazine if the full name is not needed
  • set full name to false for related magazines
Before After
grafik grafik

@BentiGorlich
Use title in "related magazines" panel
6607334 
- change the inline magazine component to use the title of the magazine if the full name is not needed
- set full name to false for related magazines
@BentiGorlich BentiGorlich added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Mar 5, 2024
@BentiGorlich BentiGorlich self-assigned this Mar 5, 2024
@melroy89
Copy link
Member

melroy89 commented Mar 5, 2024

sorry maybe a before & after screenshot could help here.

asdfzdfj pushed a commit to asdfzdfj/mbin that referenced this pull request Mar 6, 2024
@BentiGorlich @asdfzdfj
test drive MbinOrg#554: Use title in "related magazines" panel
1e4fe9f 
- change the inline magazine component to use the title of the magazine
  if the full name is not needed
- set full name to false for related magazines
melroy89
melroy89 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes it easier to read indeed. And also more consistent.

asdfzdfj
asdfzdfj approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@asdfzdfj asdfzdfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giving it a go on my instance and it seems to be working fine

@BentiGorlich BentiGorlich enabled auto-merge (squash) March 7, 2024 14:35
@BentiGorlich BentiGorlich merged commit 04276bf into main Mar 7, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the related-magazines-title branch March 7, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melroy89 melroy89 melroy89 approved these changes

@asdfzdfj asdfzdfj asdfzdfj approved these changes

Assignees

@BentiGorlich BentiGorlich

Labels
frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
MBin Kanban Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BentiGorlich @melroy89 @asdfzdfj