fix broken entry preview for non-image embeds #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-five256
approved these changes
Mar 7, 2024
the entry preview link order switching from #501 can make some entry that's not an image post but have thumbnail image to have faulty preview when expanded for example, an entry with link to youtube video would have its thumbnail attached as its image, now when opening the media preview you would get the preview of its thumbnail instead of the embed youtube player like it used to be this should fix the preview for those entries while still play nice with the new #501 image handling
asdfzdfj
force-pushed
the
fix/entry-preview-showed-thumb-not-embed
branch
from
cdb001f
to
dbdca31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the entry preview link order switching from #501 can make some entry that's not an image post but have thumbnail image to have faulty preview when expanded
for example, an entry with link to youtube video would have its thumbnail attached as its image, now when opening the media preview you would get the preview of its thumbnail instead of the embed youtube player like it used to be
(example from kbin.run)
this should fix the preview for those entries while still play nice with the new #501 image handling
(fixed/what it once was/what it should be)
