Fix profile option being marked active when viewing other profiles #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-five256
commented
Mar 8, 2024
| @@ -150,7 +150,7 @@ | |||
| <ul class="dropdown__menu"> | |||
| <li> | |||
| <a href="{{ path('user_overview', {username: app.user.username}) }}" | |||
| class="{{ html_classes({'active': is_route_name_contains('user_overview')}) }}"> | |||
| class="{{ html_classes({'active': is_route_name_contains('user_overview') and user is same as app.user}) }}"> | |||
There was a problem hiding this comment.
I swear I browsed and posted things and everything... if this ever 500s and says "user is undefined"... maybe I should add and user is defined just in case... but it didn't seem needed even after using my site a bunch... maybe I should double check in app_env prod just to make sure, wouldn't want this to cause any issues
Edit: swapped to prod and went around everywhere, seemed fine to me, you'd have to get to the user overview page while logged in and not be viewing a user somehow. checked non-existing users, banned, suspended, all seemed to work fine
nobodyatroot
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
Profileheader option gets markedactiveon any user overview page, not just your own. This fixes it so it will only be marked as active when you're viewing your own profile overview.Before (note looking at
user2asuser1)After
user2After
user1