Only count content from the last 30 days for active people #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculating the active people for a magazine can take quite some time (3 - 8 **seconds**), because literally all content in this magazine is counted by `user_id`, change that to only content from the last 30 days and voilá it takes <1 second. Granted the call is cached for an hour, but it is annoying to be the user that has to wait for that calculation. Additionally I think counting only 30 days of content results in a better picture of the "active users"
- `findPeople` is also used for the stats page which should not be limited to any time frame
nobodyatroot
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calculating the active people for a magazine can take quite some time (3 - 8 seconds), because literally all content in this magazine is counted by
user_id, change that to only content from the last 30 days and voilá it takes <1 second.Granted the call is cached for an hour, but it is annoying to be the user that has to wait for that calculation.
Additionally I think counting only 30 days of content results in a better picture of the "active users"