Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user popover for remote users #618

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Update user popover for remote users #618

merged 3 commits into from
Mar 24, 2024

Conversation

e-five256
Copy link
Member

@e-five256 e-five256 commented Mar 23, 2024

changes loc message to "View on remote instance"

remote user profile page

image

remote user popup

image

remote user OP entry sidebar

image

remote user OP post sidebar

image


remote magazine

image

remote magazine sidebar

image


OLD
  • update user popover for remote users
  • new loc token for specifying opening original profiles or magazines~
    • changed the magazine loc token that I just added in Open remote mag/user links in new window, add mag link to sidebar #616 as I feel it was also unclear as to the function, but wasn't quite convinced to add a new one, but since we might be adding one for opening profiles, felt we should add one to open for magazines. not sure how clear "open original profile/magazine" is

based on conversation from matrix, the user popover text is unclear as to what its function is. A suggestion was to remove the text and just have the icon next to the username like it now appears for remote magazines

now is the chance for any comments. different text? smaller popout icons of the alert banners? remove the alert banner completely from user profiles? add the remote icon next to usernames in the user overview box as well? feel free to give feedback

image
image

new loc token for specifying opening original profiles or magazines
@e-five256 e-five256 added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Mar 23, 2024
@e-five256 e-five256 added the needs feedback Requires a greater consensus to make an informed decision label Mar 23, 2024
@asdfzdfj
Copy link
Contributor

asdfzdfj commented Mar 23, 2024

my quick 2c:

I think the external link icon (box with pointing out arrow) is a more suitable icon for opening original actor (user/mags) profile, if anyone's looking to view the original actor profile, the external link icon answer that question better
(granted, I don't have any supporting evidence other than the fact that akkoma also does it, one might argue that the circle nodes was chosen because lemmy used the fediverse icon for it)

how akkoma does it

image

also it looks like sharkey/misskey and whatever newer mastodon (rechecked and that's mpre likely to come from glitch-soc) that infosec.exchange is running opted to put the alert banner near the top and just use a text link to original profile without icon, so perhaps it's possible to only use icon in a space constrained places (user/mag box) and just use the plain text when more space is available (like the alert banner, or even the user pop over, as it was in a line of its own)
this could also be a point for always show the remote alert banner, even when they're subscribed

how those two does it

(sharkey)
image

(infosec.exchange)
image


the problem/personal gripe that I brought up in matrix actually has more to do with the translation change, where it works nicely in alert banner for content listing, but not as well in the user popout since you're more likely to be interested in the actor profile itself rather than what they put out if you decided to click the link from that context
and for that, either use a different translation keys and tailor them for the context, or revert to the old, more generic translation or similar, like "View more on the original instance.", sharkey and new mastodon also seems to go this way, as seen in the above example

@e-five256
Copy link
Member Author

e-five256 commented Mar 23, 2024

I wouldn't expect the popout icon to have anything to do with bringing me to the original instance (without the text before it saying it would)... We need a fediverse arrow icon...


Darn, did they change mastodon recently, or was it just that subtle always. The intent was to mimic their message when you run out of posts to see of external users, like here:

image

So the banner was changed to show on the last page of pagination, but sadly doesn't seem to appear when using infinite scroll, which hopefully can be fixed


I'm fine with reverting the key and making a new one, I checked and it was translated in 2 other languages so far, but I guess ideally those can be reverted as well

@asdfzdfj
Copy link
Contributor

when fediverse arrow icon doesn't exist, my answer as to what's the next best thing is the external link icon or similar, for they are first and foremost a link to external resources

still, fair enough, come to think of it, it should be fine to use the circle node for linking to external actor, provided that its use is consistent enough that the users can learn what it means in the context (much like how I could learn that's what the fediverse icon does in lemmy), or, y'know, just use the text or lead with them

tangent: for some odd reason sharkey have another "view on remote" button in the users' 3-dot menu and it also used arrow pointing out icon (apparently it's share from phosphors icon), this menu seems to only showed up when you're logged in though

screenshot

image


well it looks like the alert banner on infosec.exchange is more likely to come from glich-soc rather than upstream mastodon, just rechecked on mastodon.social and it doesn't seems to be there, apologies for the confusion caused
(I heard that mastodon just merged a good deal of ui improvements in their latest release and I thought that part comes from this change and not glich-soc's, because some people definitely thought that those ui changes comes from glich-soc although it's not)

screenshot from mastodon.social

image


I don't think I have more objection for the translations

in any case I think I'll stop here and let others to chime in, make changes as you see fit

@e-five256
Copy link
Member Author

e-five256 commented Mar 23, 2024

I trust your opinion far more than my own; I'll swap the icons to external link and try to reword the localization. I'm not sure if it's better to revert the loc change or make a new token that's closer to what akkoma/mastodon use, as I feel like it's unclear or verbose in certain ways. "original URL" makes sense as there are terminology pages for it but there's nothing for what groups or actors are called, so I had been calling it "original profile" but that might not make sense to anyone else.

@BentiGorlich
Copy link
Member

I am fine with whatever you guys decide. 😁

reword go to original instance to not mention posts, say remote instance instead
add external link to info boxes for users for entry and post
@e-five256
Copy link
Member Author

OP updated with an attempt to match feedback. If I was off with anything, just let me know

@BentiGorlich
Copy link
Member

I think the previous icon looks better, but the "new" icon better communicates what happens when you click on it...

@BentiGorlich
Copy link
Member

I think my main gripe with the new icon is that it's just tad too big I think

@e-five256
Copy link
Member Author

e-five256 commented Mar 23, 2024

made them smaller. updated images in OP

@e-five256 e-five256 merged commit 6831356 into main Mar 24, 2024
7 checks passed
@e-five256 e-five256 deleted the e5/user-federated-box branch March 24, 2024 11:51
@e-five256 e-five256 removed the needs feedback Requires a greater consensus to make an informed decision label Mar 24, 2024
font-weight: bold;
}

i {
font-size: 0.8rem;
vertical-align: middle;
Copy link
Member Author

@e-five256 e-five256 Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bleh, just noticed this doesn't work in firefox. appears to work fine in chromium browsers. not a big deal, probably, but might want to try to adjust it later. the popout icon is just slightly low compared to the text in firefox

@melroy89 melroy89 added the enhancement New feature or request label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants