Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list display in magazine description #635

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

BentiGorlich
Copy link
Member

The magazine description used weird list styles which were additionally cut off if it was an ordered list.

Before After
Bildschirmfoto vom 2024-03-27 10-20-15 Bildschirmfoto vom 2024-03-27 10-20-06

@BentiGorlich BentiGorlich added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Mar 27, 2024
@BentiGorlich BentiGorlich self-assigned this Mar 27, 2024
@e-five256
Copy link
Member

I think they were cut off on purpose to make a > looking shape rather than the circle?

@BentiGorlich
Copy link
Member Author

I think an ordered list should still be an ordered list, especially because it is often used for rules which refer to each other like "unless it violates 2."
So my point is, that I don't get why you would mess with the list-style so an ordered list looks like a normal list and a normal list just doesn't look like a list. Doesn't make sense to me, even if it was intentional 😅

@BentiGorlich
Copy link
Member Author

maybe more feedback is needed?
@asdfzdfj @melroy89 @nobodyatroot

@nobodyatroot nobodyatroot self-requested a review March 27, 2024 13:29
Copy link
Member

@nobodyatroot nobodyatroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, seems like a hack job before if it was intentional... I'm fine with making it "proper".

Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BentiGorlich BentiGorlich merged commit 01ce55e into main Mar 27, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/magazine-description-list branch March 27, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants