Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width class missing if KBIN_PAGE_WIDTH has not been set #636

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

BentiGorlich
Copy link
Member

When the page width has not been explicitly set the width--fixed class was missing from the kbin contianer. That lead to the subscription sidebar not having a max width leading to this display:
grafik

@BentiGorlich BentiGorlich added bug Something isn't working frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Mar 27, 2024
@BentiGorlich BentiGorlich self-assigned this Mar 27, 2024
@e-five256
Copy link
Member

e-five256 commented Mar 27, 2024

It'd also be doable by removing width--fixed here as that's how the main container is styled (the lack of class means not the other other two) but this also works. Perhaps it's better to always be consistent with having a class name

(I think the thought was if someone had a malformed setting or deleted the setting for some reason it would fall back to the default, this happens for themes too, if I go delete the theme out of the class list it's not unstyled, it just falls back to the light theme. So removing it might be better because if we were to ever remove a setting, as unlikely as that might be, at least it will still have styles rather than none)

@BentiGorlich BentiGorlich merged commit bdaddb0 into main Mar 27, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/width-class-missing branch March 27, 2024 12:09
@melroy89
Copy link
Member

Ow so that was happening to me randomly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants