restore css to limit figure preview size #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added back css that limits the size of attached figure image to not exceeds 600x500px, the same size used when generating the thumbnails back when making the new sensitive figure, there was a bit of problem in keeping the image size limited without destroying the aspect ratio or causes image stretching, so that was left out and relied on generated thumbnails for limiting the figure size, however with the later introduced large image handling where the link to original image may be used for the figure instead, which can make the rendered figure bigger than what it should be
melroy89
approved these changes
Mar 28, 2024
melroy89
added
frontend
|
I would appreciate 600x600 so square images will fit perfectly |
you should still get the square image thumbnail, albeit at 500x500px because it hit the height limit first |
|
My thumbnails are generated at 600x600, it all looks fine.
…On Fri, 29 Mar 2024, 06:26 asdfzdfj, ***@***.***> wrote:
I would appreciate 600x600 so square images will fit perfectly
you should still get the square image thumbnail, albeit at 500x500px
because it hit the height limit first
—
Reply to this email directly, view it on GitHub
<#638 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALKLYOHGGOYIAOOO6MIAKULY2T3OTAVCNFSM6AAAAABFMQI5KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWGY3TKOJZG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added back css that limits the size of attached figure image to not exceeds 600x500px, the same size used when generating the thumbnails
back when making the new sensitive figure, there was a bit of problem in keeping the image size limited without destroying the aspect ratio or causes image stretching, so that was left out and relied on generated thumbnails for limiting the figure size, however with the later introduced large image handling where the link to original image may be used for the figure instead, which can make the rendered figure bigger than what it should be