add route requirements for filter options #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-five256
commented
Apr 6, 2024
breakout comment section sort as it has one less option
e-five256
commented
Apr 6, 2024
| @@ -59,8 +59,16 @@ parameters: | |||
|
|
|||
| html5_validation: true | |||
|
|
|||
| front_sort_options: top|hot|active|newest|oldest|commented | |||
| front_time_options: 6h|12h|1d|1w|1m|1y|all|∞ | |||
| front_sort_options: top|hot|active|newest|oldest|commented # TODO remove fallback after tag rework | |||
There was a problem hiding this comment.
decided to keep this for now as I don't want to touch the tag route file while the tag rework is in progress, we can change it to default_sort_options (and optionally add any other filters) later
nobodyatroot
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds filter options similar to what was done for
sortByto all other filtersright now if you go to say
/all/hot/4hit will load but the time selection is invalid and it won't affect anything. This instead makes that route 404 as it is not a valid time option. This seems like where we'd want to stop invalid options first before they get to us and we have to constantly filter out bad data (it does duplicate the values fromCriteria, but hopefully it isn't too bad to be in two main places