Fix circular ChainActivityMessage again again #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we get a like message which has url A as the "object" (or as the "id" of the "object") and the returned json has a different url B as the "id", then we went to a circular message, because the ChainActivityHandler would create the object with id B, but Like-, Dislike- and AnnounceHandler would search for an object with id A. If that occurs now, a warning will be logged and the Like-, Dislike- and AnnounceMessage that will be dispatched by the ChainActivityHandler will be adjusted to use the id that is actually in the json response from the url
BentiGorlich
added
bug
nobodyatroot
approved these changes
Apr 7, 2024
|
You could test it by publishing a message via rabbit mq management |
Ok, yep... thanks! lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we get a like message which has url A as the "object" (or as the "id" of the "object") and the returned json has a different url B as the "id", then we went to a circular message, because the ChainActivityHandler would create the object with id B, but Like-, Dislike- and AnnounceHandler would search for an object with id A.
If that occurs now, a warning will be logged and the Like-, Dislike- and AnnounceMessage that will be dispatched by the ChainActivityHandler will be adjusted to use the id that is actually in the json response from the url
Closes #668