Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin and FAQ doc updates #685

Merged
merged 10 commits into from
Apr 9, 2024
Merged

Admin and FAQ doc updates #685

merged 10 commits into from
Apr 9, 2024

Conversation

e-five256
Copy link
Member

@e-five256 e-five256 commented Apr 8, 2024

@Jerry-infosecexchange mentioned that we were missing a php8.2-bcmath requirement in our admin docs, and also wanted to get the instructions written up on how to permanently discard rabbit messages in the event a suspected infinite loop issue is encountered

Edit: Also noted rabbitmq is no longer optional, so removed places where the docs said that

add faq on discarding payload
fix typo
@e-five256 e-five256 added the documentation Improvements or additions to documentation label Apr 8, 2024
@BentiGorlich
Copy link
Member

Should I add your changes to #684 so we do not run in conflicts? A few of your points I already added when rearranging the docs. the bcmath thing is missing and I also marked redis / key DB as not longer being optional, is that correct? (I obviously thought so 😅)

@e-five256
Copy link
Member Author

I can fix the issues after

@e-five256 e-five256 marked this pull request as draft April 8, 2024 10:47
@e-five256 e-five256 marked this pull request as ready for review April 8, 2024 22:58
nobodyatroot
nobodyatroot previously approved these changes Apr 8, 2024

:::

![image](https://github.com/MbinOrg/mbin/assets/146029455/8865f0fe-f763-4980-bfc4-34b8f6b3b491)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is a new image, but if yes it should be in the images folder inside of the docs folder

@@ -107,6 +107,18 @@ so for a correct ready count you have to go to the queue specific overview.
| --------------------------------------------------------- | --------------------------------------------------- | ------------------------------------------------------------------- |
| ![Queued messages](../images/rabbit_queue_overview.png) | ![Queue overview](../images/rabbit_queue_tab.png) | ![Message Queue Overview](../images/rabbit_messages_overview.png) |

## Discarding queued messages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did write an entry about the circular message thing. Can they be combined? At least they should be next to one anotherI think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to it? I don't see it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RabbitMQ shows a really high publishing rate

Line 212

@e-five256 e-five256 marked this pull request as draft April 8, 2024 23:11
add image
redo grammar and typo fixes
@e-five256 e-five256 marked this pull request as ready for review April 8, 2024 23:49
@e-five256 e-five256 merged commit 44862f9 into main Apr 9, 2024
7 checks passed
@e-five256 e-five256 deleted the e5/doc-updates branch April 9, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants