Handle unsupported but known settings #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is called "Inter-App Audio" (IAA).
The XML property that Projucer reads and writes in the .jucer file is "iosInAppPurchases".
...but unsupported yet. Instead of aborting with: Unknown keyword: "USE_HARDENED_RUNTIME"
...but unsupported yet. Instead of aborting with: Unknown keyword: "USE_APP_SANDBOX"
...but unsupported yet. Instead of aborting with: Unknown keyword: "EXPORTER_BUNDLE_IDENTIFIER"
...but unsupported yet. Instead of aborting with: Unknown keyword: "POST_EXPORT_SHELL_COMMAND_MACOS_LINUX" or: Unknown keyword: "POST_EXPORT_SHELL_COMMAND_WINDOWS"
McMartin
force-pushed
the
handle-unsupported-but-known-settings
branch
from
20f4c02
to
210710a
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 2 commits start with
[!API]since they are technically API breaking changes. However, these 2 keywords are not supported byReprojucer.cmakeyet:ENABLE_INTER_APP_AUDIOis only for iOS, and forIN_APP_PURCHASES_CAPABILITYthere is #395 (which I will take care of amending once this PR has been merged).@MartyLake: please review, thanks!